Add an associated displacement workflow to a DataFrame #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for plot and animate
… shell and solid fields. Reciprocate for displacement workflow.
Codecov Report
@@ Coverage Diff @@
## post_refactor #309 +/- ##
=================================================
- Coverage 82.66% 82.64% -0.03%
=================================================
Files 35 35
Lines 3098 3146 +48
=================================================
+ Hits 2561 2600 +39
- Misses 537 546 +9 |
cbellot000
approved these changes
Mar 6, 2023
Closed
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* Implement DataFrame._disp_wf to associate a lazy displacement evaluation for plot and animate * Expose dpf.core.common.shell_layers as dpf.post.shell_layers * Improve type-hinting for DataFrame.columns and DataFrame.index * Add shell_layer selection to DataFrame.animate, as well as merging of shell and solid fields. Reciprocate for displacement workflow. * Improve test_dataframe_animate * Improve DataFrame.animate docstring
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* Implement DataFrame._disp_wf to associate a lazy displacement evaluation for plot and animate * Expose dpf.core.common.shell_layers as dpf.post.shell_layers * Improve type-hinting for DataFrame.columns and DataFrame.index * Add shell_layer selection to DataFrame.animate, as well as merging of shell and solid fields. Reciprocate for displacement workflow. * Improve test_dataframe_animate * Improve DataFrame.animate docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For animations on a deformed mesh.
A DataFrame holds a reference to a displacement query workflow to get displacement fields for updated coordinates whenever necessary. The ouptut of this workflow is passed to the Plotter as a deform_by argument.